I'm making a bat file that needs a CD key to start installation of a program that I made  but it doesn't accept the key I made with the code and with any key it gives this error "missing operator". The code for the bat file is
Code: [Select]echo off
rem xxxxx-xx-xxx-x
rem xxxxx-xx-xxx-3
rem xxxxx-xx-112-3
rem xxxxx-22-112-3
rem 03256-22-112-3
rem 03256/22-112/3=12
cls
echo.
echo.
echo.
echo welcome %USERNAME% to random DESKTOP wallpaper installer by Matthew fosdick
pause
cls
echo.
echo.
echo.
echo you will need 9 photos, you CD key, this CD, and aprox. 12.3 MB Hard disk space.
pause
cls
:CD
echo.
echo.
echo.
echo please enter the first 6 digits of your CD key. EX. 123456-xx-xxx-x
set /P key1=key:
cls
echo Thank you. please enter the next 2 digits of your CD key. EX. xxxxxx-78-xxx-x
set /p key2=key:
cls
echo Thank you. please enter the next 3 digits of your CD key. EX. xxxxxx-xx-901-x
set /p key3=key:
cls
echo Thank you. please enter the last digits of your CD key. EX. xxxxxx-xx-xxx-2
set /p key4=key:
cls
echo Thank you. We will check your key in the moment.
pause
set /a c="%key1%/%key2%'
set /a d="%c%-%key3%
set /a e="%d%/%key4%
if "%e%"=="12" goto con
goto CD

:con
echo Thank you. we will begin installation in a moment
pause
What key are you attempting to use?the key is at the top of the bat file
it is 03256-22-112-3
Try removing the leading 0. So the first number would be 3256 instead of 03256.iI dont get a missing operator error any more but pause command at the end is not working.Sometimes the /a switch of the set command can confuse numbers with leading zeros with something else that requires more operators.Here's your problem-

Code: [Select]set /a c="%key1%/%key2%'
set /a d="%c%-%key3%
set /a e="%d%/%key4%
1. The missing operator message is caused by those quotes which should either not be there (preferably) or at least match them start and end if you insist on having them (why?)
2. A leading zero causes set /a to read the number as an octal value.
3. See below

Code: [Select]echo off
rem correct key is 03256-22-112-3
rem therefore...
set key1=03256
set key2=22
set key3=112
set key4=3

rem neutralize any leading zeroes for each key

rem key1 has 5 digits so add 100000 (by prepending a 1)
set key1string=1%key1%
rem now take it away again with set /a
set /a key1=%key1string%-100000

rem key2 has 2 digits so add 100 (by prepending a 1)
set key2string=1%key2%
rem now take it away again with set /a
set /a key2=%key2string%-100

rem key3 has 3 digits so add 1000 (by prepending a 1)
set key3string=1%key3%
rem now take it away again with set /a
set /a key3=%key3string%-1000

rem key4 has 1 digits so add 10 (by prepending a 1)
set key4string=1%key4%
rem now take it away again with set /a
set /a key4=%key4string%-10

echo Numerical values:
echo key1=%key1%
echo key2=%key2%
echo key3=%key3%
echo key4=%key4%

set /a c=%key1%/%key2%
echo Arithmetic operation (1) %key1%/%key2%=%c%

set /a d=%c%-%key3%
echo Arithmetic operation (2) %c%-%key3%=%d%

set /a e=%d%/%key4%
echo Arithmetic operation (3) %d%/%key4%=%e%

if "%e%"=="12" echo Correct!


Code: [Select]Numerical values:
key1=3256
key2=22
key3=112
key4=3
Arithmetic operation (1) 3256/22=148
Arithmetic operation (2) 148-112=36
Arithmetic operation (3) 36/3=12
Correct!thank you it works great
does it need modification if the first GROUP has 6 digits ex 123456 Quote from: mat123 on March 06, 2010, 02:54:46 PM

does it need modification if the first group has 6 digits ex 123456