So i made a simple, little AAC to MP3 converter including the adding of MP3 Tags.
For this i use Faad (A part of FAAC), Lame & Tag

http://sourceforge.net/projects/faac/
http://www.rarewares.org/aac-decoders.php#faad2-win
http://lame.sourceforge.net/
http://www.synthetic-soul.co.uk/tag/

After writing the batch i however discovered that Faad2 is also capable of extracting the AAC from certain types of containers like MP4 files,  completely eliminating the need for me to extract those manually before feeding them to my batch.
Unless i don't have the MP4 to begin with but just the AAC file.

Sadly however this does cause an issue with my already written batch if i try to Drag & Drop a MP4 file on to the batch.

The batch i wrote renames the file created by Faad, the wav file, since it keeps the file extension of the AAC in the filename of the freshly created WAV file.
So for example; "Artist - Song.AAC" becomes "Artist - Song.AAC.WAV"

And Lame does the same with the freshly created MP3 file, that is then named "Artist - Song.WAV.MP3"

So to combat that i let it perform a rename after each process, after which Tag.exe adds tags to the MP3 and my MP3 file is done.

However when a MP4 file is dragged & dropped onto the batch instead of an AAC file.. the rename code, of course, fails.

Now the easy solution would be to created a seperate batch for MP4 files as well and use it along side the batch for the AAC files, but i'd vastly prefer to have all the code in 1 batch file instead.
So to ACCOMPLISH this i thought of letting the batch file detect what the filetype is of the file dropped onto it, and then to let it perform a GOTO to the part of the code for the AAC file and the MP4 file respectively.
I tried messing around with the IF command but to no avail.. I also tried the FOR command as well but i understand that command's capabilities even less.

So my QUESTION is simple; how do i make a batch file detect the filetype of whatever file is dragged & dropped onto it ?

Here's my code so far, please don't laugh as i'm no expert in how to utilize batch commands efficiently.

Code: [Select]ECHO OFF
color 81
:Original version by NiTeCr4Lr
:title AAC to MP3 CLI
faad -b 2 -l 2 -o %1.wav %1
title AAC to MP3 CLI
move /-Y %1.wav "C:\Program Files\AAC to MP3 CLI"
cls
ren *.aac.wav *.
ren *.aac *.wav
del %1
cls
lame -cbr -b320 -m j -q0 *.wav
del *.wav
ren *.wav.mp3 *.
ren *.wav *.mp3
Tag --auto --scheme "A - T" *.mp3
move /-Y *.mp3 "C:\Documents and Settings\NiTeCr4Lr\Bureaublad"
exit

Note:

Title after Faad since Faad hijackes the title of the Batch window and the title resets after Faad closes.

In addition, i realize the moving of the files seems inefficient but i let it do so since the shortcut to the batch file resides on my desktop, where more often than not a lot more AAC, MP4 & MP3 files reside as well. And i don't want my code touching any of those at all, especially not the "Del" part of the code
(Ok, ok.. It's also because somewhere in the code "%1" wouldn't work properly due to some path problem.. I'm very much a noob at using things like "%1" correctly.)

P.S. If anybody would be crazy enough to want to use my inefficient code to convert MP4/AAC files to MP3 files in a fairly cumbersome way, feel free to do so.
A thank you and a reference if posted elsewhere would however be appreciated. Quote

Drag & Drop a MP4 file on to the batch.

What does that mean?   

The batch i wrote renames the file created by Faad, the wav file, since it keeps the file extension of the AAC in the filename of the freshly created WAV file.
So for example; "Artist - Song.AAC" becomes "Artist - Song.AAC.WAV"

And Lame does the same with the freshly created MP3 file, that is then named "Artist - Song.WAV.MP3"

No they do not.  As Foxidrive has pointed out in his code, you coded it that way!

This modification should process the files - inside the same folder where the original files are and handle any supported extension.

If your executables are not on the path, then they will need the full location specified to the files
- so if they are all located on the desktop then it should work with "%userprofile%\desktop\"


"%userprofile%\desktop\faad.exe" rest of the line
"%userprofile%\desktop\lame.exe" rest of the line
"%userprofile%\desktop\Tag.exe" rest of the line


and if they are elsewhere and you need a guide, then let us know where they are located.

Substitution of batch parameters (%n) has been enhanced.  You can
 now use the following optional syntax:

     %~1         - expands %1 removing any surrounding quotes (")
     %~f1        - expands %1 to a fully qualified path name
     %~d1        - expands %1 to a drive letter only
     %~p1        - expands %1 to a path only
     %~n1        - expands %1 to a file name only
     %~x1        - expands %1 to a file extension only
     %~s1        - expanded path contains short names only
     %~a1        - expands %1 to file attributes
     %~t1        - expands %1 to date/time of file
     %~z1        - expands %1 to size of file
     %~$PATH:1   - searches the directories listed in the PATH
                    environment variable and expands %1 to the fully
                    qualified name of the first one found.  If the
                    environment variable name is not defined or the
                    file is not found by the search, then this
                    modifier expands to the empty string

 The modifiers can be combined to get compound results:

     %~dp1       - expands %1 to a drive letter and path only
     %~nx1       - expands %1 to a file name and extension only
     %~dp$PATH:1 - searches the directories listed in the PATH
                    environment variable for %1 and expands to the
                    drive letter and path of the first one found.

i don't get how to adjust that to get it to run for the path "C:\Program Files\AAC to MP3 CLI" instead of the desktop ..

From what you have said, all it needs is the change in the pushd command

It pushes a directory onto a stack, changes to it, and the popd pops it back off again as you gathered.
Pushd can have many levels but cd /d "C:\Program Files\AAC to MP3 CLI" will work here just as well
above the :begin label - and remove the pushd/popd lines.

Squashman has pointed out the useful help in the for /?

Code: [Select]

The most recent post runs from that folder - the pushd command changes the folder to "C:\Program Files\AAC to MP3 CLI"

Did it do something odd when you tried it?

The filetype extension in new file name issue i do not know how to address efficiently while keeping your code night and tight :p..
So apart from using that old bit of code of mine "ren *.wav.mp3 *." and then "ren *.wav *.mp3" ...