The project I have to do is create a zip file in MS Doc for all data that fails. & Then plainly put the created code with the rest of the code. Please tell me if I am on the right track & please give me hints.

Code:


ECHO OFF // Displays messages, or turns command-echoing off.
set ConfigFile=config.cfg // Allows you to change one variable or string to another.

set loglocation=d:\PPLSCRIPTS\PPL_LOGS\MDMLog%date:~-4,4%%date:~-10,2%%date:~-7,2%.txt // Allows you to change one variable or string to another.

set AlertEmail=D:\PPLSCRIPTS\AlertEmail.txt // Allows you to change one variable or string to another.

set wmailto=c:\windows\wmailto.exe // Allows you to change one variable or string to another.

set "ExistFreeSpace=0" // Allows you to change one variable or string to another.

echo Job starting.... >> %loglocation% // Displays messages, or turns command-echoing on

date /t >> %loglocation% // Appends output to the named file if it exists or creates the file and then writes to it.

time /t >> %loglocation% // Appends output to the named file if it exists or creates the file and then writes to it.

:: ** echo Calling MDMcreateCSVfiles bat file.... >> %loglocation% // Call to the file and displays.

:: ** Call MDMcreateCSVfiles //Call to the file and displays.

:: ** echo Returned from bat file call - continuing.... >> %loglocation% // Keep file running after it returns

:: ***Check if config file is there
if not exist %ConfigFile% (
echo UNABLE TO FIND THE CONFIG FILE - %ConfigFile% , used the delete the logs on MDM server. The file has been re-named or deleted. >>%loglocation%
%wmailto% -t%loglocation% %email% "-s Config file is missing"
goto :eof
) // Checks to see if file is there; if not display the following messages.

:: *** Call the subroutine; // Calls another batch file and then returns to current batch file to continue.



:: *** first argument: the name of the var in the config file to look for
:: *** second argument: the batch variable that should have the value assigned.
call :ReadConfig TotalDirs TotalNo // Calls another batch file and then returns to current batch file to continue.

call :ReadConfig email email// Calls another batch file and then returns to current batch file to continue.

call :ReadConfig Warningemail Warningemail // Calls another batch file and then returns to current batch file to continue.

call :ReadConfig extension extension // Calls another batch file and then returns to current batch file to continue.

call :ReadConfig MinFreeSpacePrcnt MinFreeSpace // Calls another batch file and then returns to current batch file to continue.

echo Log space on server.... >> %loglocation% Displays messages, or turns command-echoing off/on.

call :FreeSpace ExistFreeSpace >> %loglocation% // Calls another batch file and then returns to current batch file to continue.

setlocal EnableDelayedExpansion // Inserts strings into the command environment. The set values can be used later by programs.

FOR /L %%i IN (1,1,%TotalNo%) DO (
SET ind=%%i // Executable statement

call :ReadConfig Source!ind! source // Calls another batch file and then returns to current batch file to continue.

call :ReadConfig OlderThan!ind! olderthan // Calls another batch file and then returns to current batch file to continue.

echo Deleting files older than !olderthan! days with the file extension *.%extension% located at !source! >> %loglocation%
cd %source% // Displays messages, or turns command-echoing off/on.

echo . >>%loglocation% Displays messages, or turns command-echoing off/on.
::FORFILES -p !source! -d -!olderthan! -m *.%extension% -c "CMD /C Echo "@FILE" >> %loglocation% // executable statement



echo Starting delete... >> %loglocation%
FORFILES -p !source! -d -!olderthan! -m *.%extension% -c "CMD /C del !source!\@FILE /q & echo !source!\@FILE deleted." >> %loglocation% //
Displays messages, or turns command-echoing off/on.

echo Delete finished... >> %loglocation% // Displays messages, or turns command-echoing off/on.

echo. >>%loglocation%
) // Displays messages, or turns command-echoing off/on.

echo. // Displays messages, or turns command-echoing off/on.
echo All Deletes complete.... >> %loglocation% // Displays messages, or turns command-echoing off/on.

call :FreeSpace ExistFreeSpace>> %loglocation% // Calls another batch file and then returns to current batch file to continue.

date /t >> %loglocation% // Appends output to the named file if it exists or creates the file and then writes to it.

time /t >> %loglocation% // Appends output to the named file if it exists or creates the file and then writes to it.

echo >>%loglocation% // Displays file.

if %ExistFreeSpace% leq %MinFreeSpace% (
echo Existing free space is at %ExistFreeSpace% percent. This is less than %MinFreeSpace% percent set as the min REQUIRED free space. >> %loglocation%
%wmailto% -t%AlertEmail% %Warningemail% "-s Job MDMServerSpace: Not enough disk space on MDM server"
) // Executable statement

%wmailto% -t%loglocation% %email% "-s Files deleted on MDM server"
goto :eof // Executable statements

:: **** Subroutines start here; no changes below this line ******
:ReadConfig
for /f "tokens=2 delims==" %%a in ('type "%ConfigFile%" ^| find /i "%~1="') do set %2=%%a
goto :eof // Executable statements

:FreeSpace
@SETLOCAL ENABLEDELAYEDEXPANSION // Allows you to change one variable or string to another.

::@SETLOCAL ENABLEEXTENSIONS // Allows you to change one variable or string to another.

@CLS //

@FOR /F "tokens=1-3" %%n IN ('"WMIC LOGICALDISK GET Name,Size,FreeSpace | find /i "D:""') DO @SET FreeBytes=%%n & @SET TotalBytes=%%p //

@SET /A TotalSpace=!TotalBytes:~0,-9! // Allows you to change one variable or string to another.

@SET /A FreeSpace=!FreeBytes:~0,-10! // Allows you to change one variable or string to another.

@SET /A TotalUsed=%TotalSpace% - %FreeSpace% // Allows you to change one variable or string to another.

@SET /A PercentUsed=(!TotalUsed!*100)/!TotalSpace! // Allows you to change one variable or string to another.

@SET /A PercentFree=100-!PercentUsed! // Allows you to change one variable or string to another.
@ECHO Total space: %TotalSpace%GB // Displays messages
@ECHO Free space: %FreeSpace%GB // Displays messages
@ECHO Used space: %TotalUsed%GB // Displays messages

@ECHO Percent Used: %PercentUsed%%% // Displays messages

@ECHO Percent Free: %PercentFree%%% // Displays messages

::ENDLOCAL //

ENDLOCAL &set "%~1=%PercentFree%" //
goto :eof //


My code for the zip file:

set LOCAL_DIR=C:\temp1

if %COMPRESS% equ 1 (

echo %time% - Compressing Data Pump Files >> %SLOG% 2>&1
dir %LOCAL_DIR%\%DUMPFILE%*.* /b > %LOCAL_DIR%\dir.lst
set DIR_LIST=%LOCAL_DIR%\dir.lst


FOR /F %%A IN (%DIR_LIST%) DO (
echo Compressing: %%A

rar.exe a %LOCAL_DIR%\%%A.zip %LOCAL_DIR%\%%A
if %ERRORLEVEL% neq 0 (echo %time% - *** COMPRESS ERROR *** >> %SLOG% 2>&1)

if exist %LOCAL_DIR%\%%A.zip (del %LOCAL_DIR%\%%A /q)
)
)


A
MS DOC. what is that?
B
don't comment like that use rem or ::
for ex
ECHO OFF // Displays messages, or turns command-echoing off
becomes
@echo off
::Displays messages, or turns command-echoing off
C
what are you tying to do. fails what?
D
is this for homework?Sorry that I commented my code the way I did. I am used to dealing with C++ Programming & Java. Basically the program/ code is supposed to place all failed data into a file, I want to put it into a zip file. I am trying to figure out how to create the code so that the failed data can transfer into the zip file efficiently. P.S. I am doing this my uncle; who owns technology company. Quote from: JH0676796 on June 10, 2010, 07:39:52 AM

Sorry that I commented my code the way I did. I am used to dealing with C++ Programming & Java. Basically the program/ code is supposed to place all failed data into a file, I want to put it into a zip file. I am trying to figure out how to create the code so that the failed data can transfer into the zip file efficiently. P.S. I am doing this my uncle; who owns technology company.

batch has no provision for inline comments.

set ConfigFile=config.cfg REM Allows you to change one variable or string to another.