So for my robotics team I am making a program that will record match data on each team. I am RUNNING into a problem when I want to desplay all the teams scores at once. I am writing the scores in their own text file in c:\...\teams\%team number%\scr.txt and c:\...\teams\%team number%\ascr.txt. Currently I am using a loop to run through all the possable team numbers (1-5000) and using
Code: [Select]echo off
set /p color =<clr.txt
color %color%
title =View scores
cls
cd..
cd Teams
set teamnum=0
:loop
if not exist %teamnum% goto skip
cd %teamnum%
set /p ascr=< ascr.txt
set /p scr=< scr.txt
echo %teamnum%
echo.
echo Total        %scr%
echo Adverage %ascr%
echo ---------------------------------------------------
cd ..
:skip
set /a a=%teamnum%+1
set teamnum=%a%
if "%teamnum%" =="5001" goto end
goto loop
:end
echo.
echo.
pause
cls
cd ..
cd system
call home.bat

This takes somewhere between 5-10 minutes each time I run it, and I was wondering if there was a way that I could set the either use the %var:~#,#% or set %var#%=< dir (set each folder to a string) to SHORTEN the waiting time. Thank you so much!

EDIT: running on windows 7, but would like it to run on any windows OS.
also looking for a .bat -> .exe converter to get around this if it becomes a problem modifying it to work.
EDIT2: fixed the code (had wrong version up)It seems to me you need to sit down and really think about what needs to be done. Get the storage scheme right and worry about the code later. Do you really have 5000 teams? Or some smaller number? If you have more than a small number the scores are going to start scrolling off the screen, since showing each team's score uses 4 LINES of screen space. Why can't you have just one text file to hold all the data? Using separate folders like this is a very inefficient method, and is bound to be slow.

What does system\home.bat do?

Using your separate folders method can be speeded up a bit.

You seem to have one ascr.txt and one scr.txt in each team's folder, these files having one line which is a number?

See comments.

Code: [Select]echo off
REM is there really a Team zero?
set teamnum=0

set limit=5000

REM We will time how long it takes

set stime=%date% %time%

:loop

REM No need to keep going in and out of the folders
set foldername=Teams\%teamnum%
if not exist %foldername% goto skip

set /p ascr=< %foldername%\ascr.txt
set /p scr=<  %foldername%\scr.txt

REM I put it all on one line for neatness
echo Team %teamnum%: Total: %scr% Average: %ascr%

:skip

REM You don't need 2 variables here
REM set /a a=%teamnum%+1
REM set teamnum=%a%

REM You can do this
REM set /a teamnum=%teamnum%+1
REM or this
set /a teamnum+=1

REM Another way to compare numbers
REM See IF /? for these details
REM EQU - equal
REM NEQ - not equal
REM LSS - less than
REM LEQ - less than or equal
REM GTR - greater than
REM GEQ - greater than or equal

if %teamnum% GTR %limit% goto end

goto loop

:end

REM How long did we take?
set etime=%date% %time%
echo %limit% start %stime%
echo %limit% end   %etime%

I created 5000 (!) directories in a Teams folder and put an ascr.txt and a scr.txt containing random values in each one and then ran the above code and it took just over 35 seconds to read and display all the scores. Of course the earlier scores scrolled off the screen so I just copied the last 10 lines to show you.

You took 5 to 10 minutes?? What kind of machine?

Code: [Select]Team 4990: Total: 10  Average: 5
Team 4991: Total: 36  Average: 19
Team 4992: Total: 6  Average: 40
Team 4993: Total: 73  Average: 71
Team 4994: Total: 91  Average: 69
Team 4995: Total: 55  Average: 63
Team 4996: Total: 47  Average: 17
Team 4997: Total: 81  Average: 37
Team 4998: Total: 82  Average: 24
Team 4999: Total: 46  Average: 18
Team 5000: Total: 96  Average: 45
5000 start 04/03/2012 12:13:55.81
5000 end   04/03/2012 12:14:30.36

Quote from: Salmon Trout on March 04, 2012, 04:02:54 AM

It seems to me you need to sit down and really think about what needs to be done. Get the storage scheme right and worry about the code later. Do you really have 5000 teams? Or some smaller number? If you have more than a small number the scores are going to start scrolling off the screen, since showing each team's score uses 4 lines of screen space. Why can't you have just one text file to hold all the data? Using separate folders like this is a very inefficient method, and is bound to be slow.

What does system\home.bat do?

Using your separate folders method can be speeded up a bit.

You seem to have one ascr.txt and one scr.txt in each team's folder, these files having one line which is a number?

See comments.

Code: [Select]echo off
REM is there really a Team zero?
set teamnum=0

set limit=5000

REM We will time how long it takes

set stime=%date% %time%

:loop

REM No need to keep going in and out of the folders
set foldername=Teams\%teamnum%
if not exist %foldername% goto skip

set /p ascr=< %foldername%\ascr.txt
set /p scr=<  %foldername%\scr.txt

REM I put it all on one line for neatness
echo Team %teamnum%: Total: %scr% Average: %ascr%

:skip

REM You don't need 2 variables here
REM set /a a=%teamnum%+1
REM set teamnum=%a%

REM You can do this
REM set /a teamnum=%teamnum%+1
REM or this
set /a teamnum+=1

REM Another way to compare numbers
REM See IF /? for these details
REM EQU - equal
REM NEQ - not equal
REM LSS - less than
REM LEQ - less than or equal
REM GTR - greater than
REM GEQ - greater than or equal

if %teamnum% GTR %limit% goto end

goto loop

:end

REM How long did we take?
set etime=%date% %time%
echo %limit% start %stime%
echo %limit% end   %etime%

I created 5000 (!) directories in a Teams folder and put an ascr.txt and a scr.txt containing random values in each one and then ran the above code and it took just over 35 seconds to read and display all the scores. Of course the earlier scores scrolled off the screen so I just copied the last 10 lines to show you.

You took 5 to 10 minutes?? What kind of machine?

Code: [Select]Team 4990: Total: 10  Average: 5
Team 4991: Total: 36  Average: 19
Team 4992: Total: 6  Average: 40
Team 4993: Total: 73  Average: 71
Team 4994: Total: 91  Average: 69
Team 4995: Total: 55  Average: 63
Team 4996: Total: 47  Average: 17
Team 4997: Total: 81  Average: 37
Team 4998: Total: 82  Average: 24
Team 4999: Total: 46  Average: 18
Team 5000: Total: 96  Average: 45
5000 start 04/03/2012 12:13:55.81
5000 end   04/03/2012 12:14:30.36