I was RUNNING into some problems with set. I was trying to replace the word "Desktop" (without the quotes) with

"%userprofile%\Desktop (the quote at the front is needed).

Here is my code:
Code: [Select]set /p command=
"delims= " %%a in ("%command%") do set comma=%%a
if /i %comma%==copy set command=%command:desktop="%userprofile%\Desktop%
if /i %comma%==copy set command=%command%"
%command%
When I tried doing Copy Desktop\Messages.txt (which DOES exist) I get a file not found ERROR...

What am I doing wrong?

For /f missing from line 2.

Insert Echo %command% as line 4 to see what %command% is being set to, it looks slightly dodgy.

Try this as an alternative:
Code: [Select]Set /p command=Enter Command Path and Filename:

For /f %%a in ("%command%") do set comma=%%a

if %comma%==copy pushd %userprofile%

%command%

popd
Quote from: Dusty on April 10, 2009, 02:50:17 AM

For /f missing from line 2.

Insert Echo %command% as line 4 to see what %command% is being set to, it looks slightly dodgy.

Try this as an alternative:
Code: [Select]Set /p command=Enter Command Path and Filename:

For /f %%a in ("%command%") do set comma=%%a

if %comma%==copy pushd %userprofile%

%command%

popd

But how does your code work dusty?

Well, I hope it works.

When it's run you would respond to the Set /p with copy desktop\messages.txt

What the destination path\filename is didn't appear in your original post.

The next line simply sets %%a to the first entry in %command% which would be copy

The If command tests %comma% for copy and if true Pushd's the default directory to %userprofile% which is C:\Documents and Settings\Username

Then %command% is executed

Popd then returns the default directory to where it was before Pushd was executed.

Hope this helps and that I haven't made a fool of myself again

EDIT: Doesn't work...I think it's because %userprofile% has spaces in it. I think the only way around it is for a sub-variable...

But why did you change the FOR loop? Did I do it wrong.

set /p command=
"for /f delims= " %%a in ("%command%") do set comma=%%a
if /i %comma%==copy set command=%command:desktop="%userprofile%\Desktop%
if /i %comma%==copy set command=%command%"
%command%

Returning to your original script
This set Command to Code: [Select]"\messages.txtuserprofile" whereas what was wanted was Code: [Select]copy "c:\documents and settings\user\desktop\messages.txt"
Change the first If command line to
Code: [Select]If /i %comma%==copy set command=%comma% "%userprofile%\%command:~5%"
The second If command line is not required.

The entire script could now be:Code: [Select]set /p command=Enter Command Path\Filename

for /f "delims= " %%a in ("%command%") do set comma=%%a

if /i %comma%==copy set command=%comma% "%userprofile%\%command:~5%"

%command%
A shorter version could be:
Code: [Select]set /p command=Enter Command Path\Filename
if /i %command:~0,4%==copy set command=%command:~0,4% "%userprofile%\%command:~5%"
%command%

I don't understand why it's not working for you. Any time I run the script and enter Copy Desktop\Messages.txt the file is copied to the default directory which is C:\Documents and Settings\Dusty

Any time I run the script and enter Copy Desktop\Messages.txt d:\temp\ the file is copied to d:\temp\

Do you get the advisory message "1 File(s) copied"?

I think the only change I made to the For loop was to not include the "delims= ". Space is one of the default delimiters and therefore does not have to be specified. No, you didn't do it wrong, both methods produce the same result.