So I need to loop a 'choice /c ...' %B% amount of times, setting a new veriable each time it loops named p%b%. I got the pulling thing, but %p%b%% doesnt work, and neither does %%p%b%%%. I believe you have to do this with a for loop, but when I typed for /?, I had no clue what they were talking about. If anyone could walk me through one of these that would be GREAT! A workaround would be great too code below.


Code: [Select]@echo off
if exist stop.txt del /f stop.txt
title extraSecurity
set /p p#=<p.exs
set a=0
:ploop
set /a a+=1
set /p p%a%=<p%a%.exs
if %a% EQU %p#% goto exit.ploop
goto ploop
:exit.ploop
set b=0
:cloop
set b+=1
choice /c 1234567890qwertyuiopasdfghjklzxcvbnmABCDEFGHIJKLMNOPQRSTUVWXYZ /n /cs /m "Password?"\
set de=%p%%b%%
IF %errorlevel%==%p%b%% goto end
goto exit

:end
echo OK >>stop.txt
if not exist stop.txt goto end
exit

:exit
if exist stop.txt shutdown -s -f -t 1 & if exist stop.txt exit
goto exit
Could not test your code beyond the ploop. Need more info about the exs files and their contents. Not sure why you want/need a choice statement in a for loop. Perhaps if you told us what you're trying to accomplish, we might better find a solution.

In general, I have found using a variable value as part of another variable name, it works to call a set statement and double up on the percent symbols.

I think what you are trying to do is access an array variable. In which case you would need to use delayed expansion.Quote from: Sidewinder on June 11, 2012, 06:35:04 AM

Could not test your code beyond the ploop. Need more info about the exs files and their contents. Not sure why you want/need a choice statement in a for loop. Perhaps if you told us what you're trying to accomplish, we might better find a solution.

In general, I have found using a variable value as part of another variable name, it works to call a set statement and double up on the percent symbols.

I think what you are trying to do is access an array variable. In which case you would need to use delayed expansion.

I am attempting to create a password that does not show up on the screen, thus it would clear out all input as soon as you enter it, that was why I was using choice /c.

Control-Break can circumvent any 'protections' made by way of a batch file....

Check out this post for information on passwords and batch processing.

The posted code will not run on a 64 bit OS. Have you considered VBScript or Powershell? More verbose to be sure but you'll have more secure results.